[FIX] account_invoice_check_total: compatibility with hr_expense #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hr_expense creates moves of type in_invoice, but of course does not set the check_total field. So we skip the check if the move is linked to an expense sheet. This is a bit of a hack but a dedicated glue module sounds overkill.
sbidoul
force-pushed
the
16.0-account_invoice_check_total-hr_expense-compat-sbi
branch
from
79c7043
to
aaf8bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hr_expense creates moves of type in_invoice, but
of course does not set the check_total field.
So we skip the check if the move is linked to an
expense sheet. This is a hack but a dedicated glue module sounds overkill.