[14.0][FIX] stock_picking_invoicing: Inform field invoice_state in Stock Rule #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
sorry for the delay. The why can be seen here https://github.com/OCA/account-invoicing/pull/1025/files#r1686701138
BTW this is future proof as _get_custom_move_fields is present even in v18.
vanderleiromera
approved these changes
Oct 8, 2024
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform field invoice_state in Stock Rule
https://github.com/OCA/OCB/blob/14.0/addons/stock/models/stock_rule.py#L259
def _get_custom_move_fields(self): """ The purpose of this method is to be override in order to easily add fields from procurement 'values' argument to move data. """ return []Review of #1025
Also remove License Header in init file with only imports
cc @rvalyi @renatonlima @kevinkhao