Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_customer_no_autofollow #1781

Open
wants to merge 7 commits into
base: 16.0
Choose a base branch
from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Aug 23, 2024

No description provided.

@sbidoul
Copy link
Member Author

sbidoul commented Aug 23, 2024

/ocabot migration account_invoice_customer_no_autofollow

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 23, 2024
64 tasks
@sbidoul sbidoul force-pushed the 16.0-mig-account_invoice_customer_no_autofollow branch from 47e5bb0 to 7d62b14 Compare August 23, 2024 11:25
@sbidoul sbidoul force-pushed the 16.0-mig-account_invoice_customer_no_autofollow branch from 7d62b14 to fa49ef7 Compare August 23, 2024 11:32
@sbidoul
Copy link
Member Author

sbidoul commented Aug 23, 2024

We may want to rename this module to account_invoice_partner_no_autofollow since it equally applies to vendor bills.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional LGTM. Pls check the comment regarding maintainers.

account_invoice_customer_no_autofollow/__manifest__.py Outdated Show resolved Hide resolved
@ivs-cetmix
Copy link
Member

We may want to rename this module to account_invoice_partner_no_autofollow since it equally applies to vendor bills.

@sbidoul this is a good idea. However I wouldn't do this to avoid potential migration issues.

@sbidoul
Copy link
Member Author

sbidoul commented Aug 23, 2024

I wonder why such module is not more popular. I kind of feel I'm missing something obvious...

@StefanRijnhart since you reviewed the same for sale orders, you may be interested in this one.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see no issues with the rename, because there is no data associated with this module. It would be nice to see the config parameter renamed on migration (after using openupgrade's rename_modules) or (re)installation.

@ivs-cetmix
Copy link
Member

Yup, this means that there we should add a migration script

Thanks! I see no issues with the rename, because there is no data associated with this module. It would be nice to see the config parameter renamed on migration (after using openupgrade's rename_modules) or (re)installation.

@StefanRijnhart Yup, actually we can keep the existing config parameter name or add a migration script it we really need to rename it.

Copy link

@dessanhemrayev dessanhemrayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelbn
Copy link
Member

Hello @sbidoul

I wonder why such module is not more popular. I kind of feel I'm missing something obvious...

We don't have and request in clients. They have customers as followers and there are not any problem reported in many years.

🤔

Best regards!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants