-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "generate_diagram.py" script #1384
Updated "generate_diagram.py" script #1384
Conversation
Just one tiny thing to think about for the future. The color combinations aren't super friendly to people with color-blindness (green+red+blue-green-ish). Since the diagram is already a little tricky to wrap your head around we may want to watch out for this aqua vs red since they are currently conveying parts of the hierarchy. |
Thanks for the comment @zm711 I checked out the figure at https://www.color-blindness.com/coblis-color-blindness-simulator/ and I think that even for red-blindness the colours are distinct, but I'm happy to take suggestions for different colours. |
As long as you check then it's probably good. I just like making sure that someone has checked. :) |
no. It is not a problem for a group to contain objects that belong to different segments, in fact that's one of the main use cases for Group. (Groups can no longer contain entire Segment objects, but that is not shown in the figure) |
Cool. So it would be incorrect if the the orange box was over one or both black boxes. I see. Thanks @apdavison ! |
Merci Andrew and Julia for this Heoric patch on this very old and dirty diagram generation code. |
based on changes by Julia Sprenger in #1026