-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove setting of metadata in Runner #2107
Conversation
self._namespace_check = _namespace_check | ||
|
||
# Set the metadata being passed.. | ||
metadata(self._current_metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to do this at all. Basically, we create a Metaflow object that has self.metadata in it. We want to initialize self.metadata to be the one from self._current_metadata.
@@ -540,16 +548,17 @@ def _unpickle_284(self, data): | |||
) | |||
|
|||
def _unpickle_2124(self, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add another version of course. So we can unpickle all versions of objects.
run_object = Run(pathspec, _namespace_check=False) | ||
run_object = Run( | ||
pathspec, _namespace_check=False, _current_metadata=content.get("metadata") | ||
) | ||
return ExecutingRun(self, command_obj, run_object) | ||
|
||
def run(self, **kwargs) -> ExecutingRun: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is something in deployer which is where I ran into it.
Superseded by #2113 |
No description provided.