fix: argo and step-function config param mapping #2105
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Oct 17, 2024
| @@ -476,6 +476,8 @@ def _process_parameters(self): | |||
| has_schedule = self._cron() is not None | |||
| seen = set() | |||
| for var, param in self.flow._get_parameters(): | |||
| if param.IS_FLOW_PARAMETER: | |||
There was a problem hiding this comment.
@saikonen can you add a comment here for why we continue? would be helpful later on
romain-intel
force-pushed
the
feat/configs
branch
from
5fdb25c
to
bc57f77
Compare
Will only print stuff when there is an error and will print it in a non-interleaved manner.
saikonen
force-pushed
the
fix/argo-config-param-mapping
branch
from
fef6ec1
to
dfe05dc
Compare
saikonen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to fix argo/step function handling of config parameters