Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer using inheritance w/ stubs #2093

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

romain-intel
Copy link
Contributor

No description provided.

@madhur-ob
Copy link
Collaborator

from_deployment method doesn't work, it has the following issue:

    173 def f(
    174     identifier: str,
    175     metadata: Optional[str] = None,
    176     impl: str = DEFAULT_FROM_DEPLOYMENT_IMPL.replace("-", "_"),
    177 ):
    178     if impl in allowed_providers:
--> 179         return allowed_providers[impl].deployed_flow_type.from_deployment(
    180             identifier, metadata, impl
    181         )

AttributeError: 'property' object has no attribute 'from_deployment'

@romain-intel romain-intel force-pushed the madhur-ob-deployer-from-existing branch 2 times, most recently from 873a87d to 7596d21 Compare October 22, 2024 18:36
@romain-intel romain-intel changed the base branch from fix/subclass-deployer to master October 22, 2024 18:47
@romain-intel romain-intel changed the title Madhur ob deployer from existing Deployer using inheritance w/ stubs Oct 22, 2024
@romain-intel romain-intel force-pushed the madhur-ob-deployer-from-existing branch from 7596d21 to 4b09e52 Compare October 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants