use cwd in nbrunner and nbdeployer

[madhur-ob]

No description provided.

[romain-intel]

Am fine with this but it does change the UX -- has this been validated?

[madhur-ob]

the issue that people were running into -- other python files / directories are not importable if we use a temporary directory.
users had to pass the value of base_dir explicitly..

while we can still pass anything really, the base_dir will now be the current working directory..
i.e. the directory where the .ipynb exists..

any files / other dirs that are sisters i.e. at the same level of the notebook (the .ipynb file..)
will now be accessible and importable in the flow being written...

[savingoyal]

@romain-intel i don't think there is any change in the UX perse - but this is a bug fix to ensure packaging works as expected.

[romain-intel]

oh totally get the change and I agree with it -- I am just saying it is a change in UX exactly for the reason you mention: before we were running in an isolated clean environment and now it has a bunch more stuff. I agree that most people want the second behavior which this PR does so I am in favor of the change. I am simply pointing out that this is a behavior change (which I agree most people will view as a "bug fix" but it does change the documented behavior (clearly shown since the doc strings are changing too))

[savingoyal]

yep - we are in agreement.