Refactor system event logger and monitor, add new metrics #2065
+31
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talsperre
force-pushed
the
dev/add-decorator-events
branch
from
4de523e
to
e5ae007
Compare
|
Something seems to have gotten lost -- there is no graph_info anymore. |
talsperre
force-pushed
the
dev/add-decorator-events
branch
from
e5ae007
to
7f07086
Compare
talsperre
changed the title
talsperre
changed the title
talsperre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the notion of a separate global context from
system_monitorandsystem_logger. User's can now implement their event loggers and monitors to make use of the current singleton instead.Additionally, it adds the
graph_infoobject to the current singleton, but it is not directly exposed to the end user.