Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Abstracting away SubcommandManager's signal handling #2058

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Abstracting away SubcommandManager's signal handling #2058

wants to merge 14 commits into from

Commits on Oct 22, 2024

  1. Add an async sigint handler

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b46a4ac View commit details
    Browse the repository at this point in the history

  2. Improve async runner interface

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b194ab1 View commit details
    Browse the repository at this point in the history

  3. Fix error handling in *handle_timeout

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ae7ec7c View commit details
    Browse the repository at this point in the history

  4. Fix async_read_from_file_when_ready

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7ed220e View commit details
    Browse the repository at this point in the history

  5. Simplify async_kill_processes_and_descendants

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e728aed View commit details
    Browse the repository at this point in the history

  6. Group kill_process_and_descendants into single command

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f4466ac View commit details
    Browse the repository at this point in the history

  7. Call sigint manager only for live processes

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    244030e View commit details
    Browse the repository at this point in the history

  8. Guard against empty pid list in sigint handler

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1e44074 View commit details
    Browse the repository at this point in the history

  9. Cleanup comments

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8532764 View commit details
    Browse the repository at this point in the history

  10. Reimplement CommandManager.kill in terms of kill_processes_and_descen… 

    …dants
    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fcb652d View commit details
    Browse the repository at this point in the history

  11. Use fifo for attribute file

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e850e68 View commit details
    Browse the repository at this point in the history

  12. Add SignalManager

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a89c47a View commit details
    Browse the repository at this point in the history

  13. Use run_coroutine_threadsafe instead of create_task

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    32c0e0d View commit details
    Browse the repository at this point in the history

  14. Fix signal manager class vars

    @filipcacky
    filipcacky committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    81da2df View commit details
    Browse the repository at this point in the history