Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slack ui_link #2055

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Fix slack ui_link #2055

merged 3 commits into from
Oct 14, 2024

Conversation

t-houssian
Copy link
Contributor

@t-houssian t-houssian commented Sep 23, 2024 •
edited
Loading

The slack ui_link needs a slight bug fix. The url is missing a slash.

Why This Matters:

User Experience:

  • Incorrect URLs in notifications can frustrate users and hinder workflow.
  • Ensuring correct URL formatting improves reliability.

Code Maintainability:

  • Proper handling of strings and URLs prevents bugs.
  • Consistent practices make the code easier to understand and maintain.

Thanks y'all, and great project here!

@t-houssian
Copy link
Contributor Author

@saikonen I removed the lstrip part. Should be good now.

saikonen
saikonen previously approved these changes Oct 11, 2024
View reviewed changes
@saikonen saikonen merged commit 561c5a9 into Netflix:master Oct 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikonen saikonen saikonen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-houssian @saikonen