runner fixes and enhancements #2053
Conversation
| loop = asyncio.get_running_loop() | ||
| loop.add_signal_handler( | ||
| signal.SIGINT, | ||
| lambda: self._handle_sigint(signum=signal.SIGINT, frame=None), |
There was a problem hiding this comment.
I think this would be better with asyncio.create_task and a wrapped async signal handler.
By using a synchronous one with time.sleep and subprocess.check_call, instead of awaiting on asyncio.sleep and asyncio.create_subprocess_exec, you're blocking other coroutines from running in the meantime.
There was a problem hiding this comment.
Thanks @filipcacky, would you like to contribute this change?
There was a problem hiding this comment.
If you want, either you can push on top of my branch / fork..
OR we can merge this and you can raise another.. what say?
There was a problem hiding this comment.
Hey, sorry, I'm from EU so it's a bit late for me 🙂 I've implemented this in async in my MR. You can copy it over from there.
There was a problem hiding this comment.
No worries, you can contribute tomorrow as discussed in DM 😄
There was a problem hiding this comment.
Didn't have permissions to push/create PR to your remote, so I added my changes here filipcacky@5dd4aab. Feel free to cherry-pick.
This reverts commit cbfaea9.
This PR is inspired by a few ideas from
poll()not available for theProcessobject created async)It also comes with: