WIP: Initial commit for spin steps #2036
Open
+1,746
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| help="Command used to spin up a single task based on the artifacts from " | ||
| "a previous run or artifacts provided by the user." | ||
| ) | ||
| @click.argument("step-name") |
There was a problem hiding this comment.
some of these should probably be taken from the start (ie: top-level) options. For spin, we should just ignore them and set them to local. I believe we could override them at that level using the invoked_subcommand that click provides (and checking if it is spin).
metaflow/task.py
Outdated
| output.init_task() | ||
|
|
||
| # How we access the input and index attributes depends on the execution context. | ||
| # If spin is set to True, we short-circuit attribute access to getatttr directly |
| @@ -272,6 +273,8 @@ def index(self) -> Optional[int]: | |||
| int, optional | |||
| Index of the task in a foreach step. | |||
| """ | |||
| if self._spin: | |||
| return getattr(self, "_spin_index") | |||
There was a problem hiding this comment.
nit: return self._spin_index
| @@ -292,6 +295,8 @@ def input(self) -> Optional[Any]: | |||
| object, optional | |||
| Input passed to the foreach task. | |||
| """ | |||
| if self._spin: | |||
| return getattr(self, "_spin_input") | |||
metaflow/task.py
Outdated
| print("%s failed:" % self.flow, file=sys.stderr) | ||
| raise | ||
| finally: | ||
| # TODO: Persist the output artifacts to local datastore |
There was a problem hiding this comment.
there is a task_finished missing as well (after the persist of artifacts)
| ) | ||
|
|
||
| try: | ||
| return __getattr__(self.task.artifacts, name) |
| f"`{self.step_name}`." | ||
| ) | ||
|
|
||
| raise AttributeError( |
There was a problem hiding this comment.
is this ever reached?
talsperre
force-pushed
the
dev/baby-steps
branch
from
e3df8b4
to
58d96e1
Compare
talsperre
force-pushed
the
dev/baby-steps
branch
from
9103482
to
517203d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for spinning up "baby" steps in Metaflow by using the client API as an input datastore.