Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamps to conda debug logs #1889

Merged
merged 1 commit into from
Jun 19, 2024
Merged

add timestamps to conda debug logs #1889

merged 1 commit into from
Jun 19, 2024

Conversation

savingoyal
Copy link
Collaborator

@savingoyal savingoyal commented Jun 18, 2024

to get output of the nature of
Screen Shot 2024-06-17 at 7 40 16 PM

@nflx-mf-bot
Copy link
Collaborator

Testing[765] @ 1cd9173

@nflx-mf-bot
Copy link
Collaborator

Testing[765] @ 1cd9173 had 7 FAILUREs.

@romain-intel
Copy link
Contributor

Test failures are OK (unrelated dependency change)

storage = self.datastore(
_datastore_packageroot(self.datastore, self.echo)
)
storage = self.datastore(_datastore_packageroot(self.datastore, echo))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be self.logger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is intentional

Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit (we don't test this code so can't say conclusively) but otherwise can merge anytime.

@savingoyal savingoyal merged commit 9de2ae5 into master Jun 19, 2024
27 checks passed
@savingoyal savingoyal deleted the timestamos branch June 19, 2024 16:30
savingoyal added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants