-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timestamps to conda debug logs #1889
Conversation
Testing[765] @ 1cd9173 |
Testing[765] @ 1cd9173 had 7 FAILUREs. |
Test failures are OK (unrelated dependency change) |
storage = self.datastore( | ||
_datastore_packageroot(self.datastore, self.echo) | ||
) | ||
storage = self.datastore(_datastore_packageroot(self.datastore, echo)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be self.logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit (we don't test this code so can't say conclusively) but otherwise can merge anytime.
This reverts commit 9de2ae5.
to get output of the nature of