allow output to be hidden in nbrun() #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhur-ob
reviewed
May 27, 2024
| @@ -50,7 +50,7 @@ class NBRunner(object): | |||
| def __init__( | |||
| self, | |||
| flow, | |||
| show_output: bool = False, | |||
| show_output: bool = True, | |||
There was a problem hiding this comment.
So, the self.runner is used in other places too such as run, resume, async_run and async_resume -- and the default way here should be to suppress outputs.
It is only for nbrun and nbresume methods that we want to show outputs by default.
Setting the default value to True will make it show for the run, resume, async_run and async_resume methods as well, which we don't want..
There was a problem hiding this comment.
we want to show output by default for run and resume. For async_ calls, show_output doesn't have any effect, right?
There was a problem hiding this comment.
yeah, show output should have no effect on async_
madhur-ob
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.