[card-client] make Card.get_data more efficient
#1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valayDave
commented
Feb 20, 2024
Comment on lines
+64
to
+69
| data_paths = self._card_ds.extract_data_paths( | ||
| card_type=self.type, card_hash=self.hash, card_id=self._card_id | ||
| ) | ||
| if len(data_paths) == 0: | ||
| return None | ||
| self._data_path = data_paths[0] |
There was a problem hiding this comment.
s3 list calls are costly so caching the location is useful.
- Helps ensure that stale updates from a server can be ignored
valayDave
commented
Feb 21, 2024
| return { | ||
| "reload_token": _reload_token(), | ||
| "data": json_msg, | ||
| "created_on": time.time(), |
There was a problem hiding this comment.
driveby change: add a timestamp in the dataupdate call. It helps discard data updates that maybe stale.
valayDave
commented
Feb 22, 2024
| @@ -14,8 +14,6 @@ export const cardData: Writable<types.CardResponse | undefined> = | |||
| (window as any).metaflow_card_update = ( | |||
| dataChanges: Record<string, types.CardComponent> | |||
| ) => { | |||
| console.log("metaflow_card_update", dataChanges, cardData?.update); | |||
There was a problem hiding this comment.
Driveby change: remove un-necessary console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.