Allow port number to be configurable in @kubernetes. #1745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Done: - Verified that pods with @kubernetes(port=N) start with port N configured correctly in the pod spec. - Verified that pods without port=N work as expected - Verified that @kubernetes(port=N) works as expected with Argo workflows
madhur-ob
reviewed
Feb 27, 2024
madhur-ob
previously approved these changes
Feb 27, 2024
|
Mergeable anytime from my end -- no impact on core. |
valayDave
pushed a commit
to valayDave/metaflow
that referenced
this pull request
Mar 27, 2024
Linked to upstream : [Netflix#1745] Testing Done: - Verified that pods with @kubernetes(port=N) start with port N configured correctly in the pod spec. - Verified that pods without port=N work as expected - Verified that @kubernetes(port=N) works as expected with Argo workflows
valayDave
pushed a commit
to valayDave/metaflow
that referenced
this pull request
Mar 27, 2024
Linked to upstream : [Netflix#1745]
|
Can merge #1793 in favor of this as I have resolved the pre-commit issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing Done: