fix: allow dot files with --package-suffixes
#1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing[636] @ aada8b1 |
|
Testing[636] @ aada8b1 had 7 FAILUREs. |
madhur-ob
previously approved these changes
Feb 19, 2024
romain-intel
previously approved these changes
Feb 29, 2024
| @@ -88,8 +88,6 @@ def _walk(self, root, exclude_hidden=True, suffixes=None): | |||
| # if path and (path[0] == '.' or './' in path): | |||
| # continue | |||
| for fname in files: | |||
There was a problem hiding this comment.
maybe a slightly safer and less expensive check would be something like:
if (fname[0] == "." and fname in suffixes) or (fname[0] != "." and any(fname.endswith(suffix) for suffix in suffixes):
This would restrict to including just files like .env and not check all random . files.
But am fine with this change as well.
There was a problem hiding this comment.
going with your suggestion as the initial implementation ended up including arbitrary hidden files with known extensions, e.g. .hidden.py
There was a problem hiding this comment.
Good point -- I hadn't even thought of that.
saikonen
dismissed stale reviews from romain-intel and madhur-ob
via
9e31719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow files that start with . to be added via
--package-suffixescloses #1741