Various fixes in the env escape code #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now handle exceptions that are also proxied classes better We canonicalize more names to better deal with aliases in proxied libraries. Other cleanup
romain-intel
force-pushed
the
fix/escape-hatch-exceptions
branch
from
a49b2b3
to
674f986
Compare
wangchy27
reviewed
Mar 14, 2024
| # - proxied functions | ||
| # - classes that are proxied regular classes AND proxied exceptions | ||
| # - classes that are proxied regular classes AND NOT proxied exceptions | ||
| # - clases that are NOT proxied regular classes AND are proxied exceptions |
| ) | ||
|
|
||
| # Detect circular aliaes. If a user lists ("a", "b") and then ("b", "a"), we |
| # actually: | ||
| # - the class itself (which is a stub) | ||
| # - the class in the capacity of a parent class (to another exception | ||
| # presumably). The reason for this is that if we have a exception/proxied |
| # - A_parent inherits from the actual parents of A (let's assume a | ||
| # builtin exception) | ||
| # - A inherits from (Stub, A_parent) | ||
| # - B_parent inherints from A_parent and the builtin Exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now handle exceptions that are also proxied classes better
We canonicalize more names to better deal with aliases in proxied libraries.
Other cleanup