Temporary way of passing *some* environment variables to remote nodes #1564
Conversation
This will be revisited with a more generalized solution where each individual decorator will be able to set the variables it wants to pass along
There was a problem hiding this comment.
as a temp solution this seems great. No worry about leaking user-specific envs with the whitelisting+config_values approach.
If I understood it correctly, then one gotcha that I thought of regarding extensions was that any env var that should be passable, needs to be accessed by from_conf before it is made available through config_values
What was the specific use-case for this improvement?
|
@saikonen : this is to make sure the netflix conda extension works cleanly here as well. And yes, things need to go through from_conf (any conf needs to go through that). Future improvement will probably use something like @Environment to pass env vars (and some combo of the functionality from config_values). But for now this should be good. |
This will be revisited with a more generalized solution where each individual decorator will be able to set the variables it wants to pass along