chore: support disable for new conda deco #1532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
commented
Sep 12, 2023
* correctly choose conda platform * fix conda step_init comment * delete unused files from pypi plugin * add TODO and add missing default param to executable()
* add installation step for micromamba binary if none can be found * add error handling to micromamba install
savingoyal
force-pushed
the
pip-decorator
branch
from
42633ee
to
294645b
Compare
saikonen
force-pushed
the
chore/support-disable-for-new-conda
branch
from
35ace52
to
5cd9d71
Compare
* add docstrings to conda flow and step decorators * unify micromamba binary download locations * explicitly except KeyError * unused import
saikonen
force-pushed
the
chore/support-disable-for-new-conda
branch
from
d1a052c
to
1f4778a
Compare
saikonen
force-pushed
the
chore/support-disable-for-new-conda
branch
from
1f4778a
to
7b06779
Compare
saikonen
commented
Sep 15, 2023
| yield environment["id_"], { | ||
| **{ | ||
| k: v | ||
| for k, v in environment[type_].items() | ||
| if k != "platforms" | ||
| if k in ["python", "packages"] |
There was a problem hiding this comment.
went with the simplest way for restricting passing non-supported parameters to the solvers.
savingoyal
force-pushed
the
pip-decorator
branch
from
381217d
to
3fab34b
Compare
|
fixed and merged to #1505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for
disabled=for the new conda flow and step decorators. Also supportdisabled=for PyPI decorator.