Enabling Ray Cluster #1501
Closed
Enabling Ray Cluster #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
July 21, 2023 17:15
Add error handling, node watcher, and auto checkpoint_path var
rileyhun
changed the title
saikonen
reviewed
Aug 28, 2023
| from threading import Thread | ||
| from metaflow.exception import MetaflowException | ||
| from metaflow.unbounded_foreach import UBF_CONTROL | ||
| from metaflow.plugins.parallel_decorator import ParallelDecorator, _local_multinode_control_task_step_func |
There was a problem hiding this comment.
small change proposal: Importing internal method might lead to breaking changes in the future. Could this be done with only the ParallelDecorator and relying on super() in the task_decorate?
| break | ||
| except ImportError: | ||
| print("Ray is not installed. Installing latest version of ray-air package.") | ||
| subprocess.run([sys.executable, "-m", "pip", "install", "-U", "ray[air]"], check=True) |
There was a problem hiding this comment.
is the -U necessary? This could lead to overhead/breakage in task startups even with custom built images that have Ray installed, whenever a new version is released.
|
This PR is encapsulated in https://github.com/outerbounds/metaflow-ray and we can close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We require the ability to activate a Ray cluster using AWS Batch multi-node parallel jobs
This PR accomplishes the following:
@ray_paralleldecorator that a user can use to effectively spin up a Ray cluster from AWS Batch multi-node parallel job. This decorator follows the official Ray documentation on setting up Ray on-premise.What has changed
@ray_paralleldecorator modeled from base@paralleldecoratorNotes
Testing evidence