Fix signal handling in SubprocessManager #2039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipcacky
commented
Sep 17, 2024
Comment on lines
+79
to
+87
| async def handle_sigint(): | ||
| await self._async_handle_sigint() | ||
|
|
||
| asyncio.get_running_loop().add_signal_handler( | ||
| signal.SIGINT, lambda: asyncio.create_task(handle_sigint()) | ||
| ) |
There was a problem hiding this comment.
Closure required in order to capture self, also asyncio signal handlers can't be async.
filipcacky
force-pushed
the
fc/subprocess_sigint
branch
from
e6bfdd1
to
8fe1164
Compare
|
closing in favor of #2053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2038
I've moved signal handling to SubprocessManager and implemented it via asyncio/signal depending on the running context.