return event identifier in response to ArgoEvent.publish (#1587)

* return event id for ArgoEvent * more changes
Netflix · Oct 12, 2023 · efd7a85 · efd7a85
1 parent b76e512
commit efd7a85
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/metaflow/plugins/argo/argo_events.py b/metaflow/plugins/argo/argo_events.py
@@ -108,25 +108,24 @@ def publish(self, payload=None, force=True, ignore_errors=True):
                 # TODO: do we need to worry about certs?
 
                 # Use urllib to avoid introducing any dependency in Metaflow
+                data = {
+                    "name": self._name,
+                    "payload": {
+                        # Add default fields here...
+                        "name": self._name,
+                        "id": str(uuid.uuid4()),
+                        "timestamp": int(time.time()),
+                        "utc_date": datetime.utcnow().strftime("%Y%m%d"),
+                        "generated-by-metaflow": True,
+                        **self._payload,
+                        **payload,
+                    },
+                }
                 request = urllib.request.Request(
                     self._url,
                     method="POST",
                     headers={"Content-Type": "application/json", **headers},
-                    data=json.dumps(
-                        {
-                            "name": self._name,
-                            "payload": {
-                                # Add default fields here...
-                                "name": self._name,
-                                "id": str(uuid.uuid4()),
-                                "timestamp": int(time.time()),
-                                "utc_date": datetime.utcnow().strftime("%Y%m%d"),
-                                "generated-by-metaflow": True,
-                                **self._payload,
-                                **payload,
-                            },
-                        }
-                    ).encode("utf-8"),
+                    data=json.dumps(data).encode("utf-8"),
                 )
                 retries = 3
                 backoff_factor = 2
@@ -137,7 +136,7 @@ def publish(self, payload=None, force=True, ignore_errors=True):
                         print(
                             "Argo Event (%s) published." % self._name, file=sys.stderr
                         )
-                        break
+                        return data["payload"]["id"]
                     except urllib.error.HTTPError as e:
                         # TODO: Retry retryable HTTP error codes
                         raise e