fix: required deposit fix when available storage is higher than needed (

#40) * fix: required deposit fix when available storage is higher than needed * chore: fixed lint error
NEARBuilders · Jul 30, 2024 · 99f9e8d · 99f9e8d
1 parent 4973ce1
commit 99f9e8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts
@@ -109,12 +109,12 @@ describe('calculateRequiredDeposit()', () => {
         data,
         storageBalance: {
           available: BigInt(storageCostOfData.plus('1').toFixed()),
-          total: BigInt(storageCostOfData.minus('1').toFixed()),
+          total: BigInt(storageCostOfData.plus('10').toFixed()),
         },
       });
 
       // assert
-      expect(result.toFixed()).toBe('1');
+      expect(result.toFixed()).toBe('0');
     });
   });
 });
diff --git a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts
@@ -3,7 +3,6 @@ import BigNumber from 'bignumber.js';
 // constants
 import {
   MINIMUM_STORAGE_IN_BYTES,
-  ONE_YOCTO,
   STORAGE_COST_PER_BYTES_IN_ATOMIC_UNITS,
 } from '@app/constants';
 import { EXTRA_STORAGE_BALANCE } from './constants';
@@ -48,5 +47,5 @@ export default function calculateRequiredDeposit({
   // if the storage deposit available is less than the cost of storage, use the difference as the required deposit
   return storageDepositAvailable.lt(storageCostOfData)
     ? storageCostOfData.minus(storageDepositAvailable)
-    : new BigNumber(ONE_YOCTO);
+    : new BigNumber('0');
 }