MUL-1942: cd alpine builds #125
Conversation
Enmk
commented
Dec 4, 2018
•
Enmk
commented
- Fixed building and packaging docker images for alpine with musl static library.
- Updated startup banners for node services and multy back.
- Separate Dockerfile for multy-back-builder image: Dockerfile_multy-back-builder
- Using CanaryTest mode for multy-back and ns to verify that images was built Ok.
Enmk
force-pushed
the
MUL-1942_CD_alpine_builds
branch
from
32aa6cf
to
0dabc3a
Compare
Dockerfile
Outdated
| RUN curl http://www.musl-libc.org/releases/musl-1.1.20.tar.gz > musl-1.1.20.tar.gz \ | ||
| && tar -xf musl-1.1.20.tar.gz \ | ||
| && cd ./musl-1.1.20 \ | ||
| && ./configure --prefix=/usr && make && make install |
There was a problem hiding this comment.
https and pipe to tar - curl https://www.musl-libc.org/releases/musl-1.1.20.tar.gz | tar xz
| @@ -1,39 +1,54 @@ | |||
| # Builder image that builds all the multy-back and all node services | |||
| # multyio/multy-back-builder has all dependencies cached | |||
| # Based on golang:1.9.4 | |||
There was a problem hiding this comment.
Link to Dockerfile for multy-back-builder
There was a problem hiding this comment.
It is now committed as separate Dockerfile, see Dockerfile_multy-back-builder and corresponding make targets:
docker-build-builder-image
docker-retag-builder-image
docker-push-builder-image
|
|
||
| # Base image for all images with executable application | ||
| # Sets important arguments and labels. |
There was a problem hiding this comment.
This comment is excessive. )
| lasttag string | ||
| buildtime string | ||
|
|
There was a problem hiding this comment.
If it is interesting to aim for reproducible builds then "Timestamps are best avoided"
If a date is required to give users an idea on when the software was made, it is better to use a date that is relevant to the source code instead of the build: old software can always be built later. Like version information, it’s best to extract such a date from the revision control system or from a changelog.
| config.ReadGlobalConfig(&globalOpt, "multy configuration") | ||
| log.Infof("CONFIGURATION=%+v", globalOpt.SupportedNodes) | ||
|
|
||
| log.Info("============================================================") |
| log.Infof("CONFIGURATION=%+v", globalOpt) | ||
|
|
||
| log.Info("============================================================") | ||
| log.Info("Node service ETH starting") |
There was a problem hiding this comment.
log.Info("=======================================[ Node Service]===[ ETH ]")
|
|
||
| log.Info("Reading configuration...") | ||
| config.ReadGlobalConfig(&globalOpt, "multy configuration") | ||
| log.Infof("CONFIGURATION=%+v", globalOpt) |
There was a problem hiding this comment.
according with #97
don't print configuration or globalOpt.Database.Password = "***"
There was a problem hiding this comment.
Not all fixes from master/release were ported yet, and this line here is just something that existed before, rearranged.
* Fixed building and packaging docker images for alpine with musl static library. * Updated startup banners for node services and multy back. * Separate Dockerfile for multy-back-builder image: Dockerfile_multy-back-builder. * Using CanaryTest mode for multy-back and ns to verify that images was built Ok.
Enmk
force-pushed
the
MUL-1942_CD_alpine_builds
branch
from
2e6b7fe
to
46a4f4e
Compare
