#520 [feat] 인가체제 변경 #523
Closed
#520 [feat] 인가체제 변경 #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyundoh
reviewed
Oct 6, 2024
Comment on lines
52
to
60
| @Override | ||
| @DeleteMapping("/{topicId}") | ||
| @UserAuthAnnotation(UserAuthenticationType.OWNER) | ||
| public ResponseEntity<SuccessResponse> deleteTopic( | ||
| @TopicIdPathVariable final Long topicId, | ||
| @UserId final Long userId, | ||
| @PathVariable("topicId") final String topicUrl | ||
| ) { | ||
| topicService.deleteTopic(userId, topicId); | ||
| topicService.deleteTopic(topicId); | ||
| return ResponseEntity.ok(SuccessResponse.of(SuccessMessage.TOPIC_DELETE_SUCCESS)); |
There was a problem hiding this comment.
P2
{topicId}로 요청이 들어올 경우 moimId기반으로 owner인지 확인하는 로직에서 에러가 날 것 같은데 아닌가요!?
| return ResponseEntity.ok(SuccessResponse.of(SuccessMessage.TOPIC_DELETE_SUCCESS)); | ||
| } | ||
|
|
||
| @PutMapping("/{topicId}") | ||
| @UserAuthAnnotation(UserAuthenticationType.OWNER) | ||
| public ResponseEntity<SuccessResponse> putTopic( |
Comment on lines
+31
to
36
| @UserAuthAnnotation(UserAuthenticationType.OWNER) | ||
| public ResponseEntity<SuccessResponse> deleteMember( | ||
| @PathVariable("writerNameId") final Long writerNameId, | ||
| @UserId final Long userId | ||
| @PathVariable("writerNameId") final Long writerNameId | ||
| ) { | ||
| writerNameService.deleteWriterNameById(writerNameId, userId); | ||
| writerNameService.deleteWriterNameById(writerNameId); | ||
| return ResponseEntity.ok(SuccessResponse.of(SuccessMessage.MOIM_MEMBER_DELETE_SUCCESS)); |
|
말씀해주신 부분이 맞네요🥲 일단 풀리퀘 닫고 다시 올리겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
아래 API 들에 대하여 수정했습니다!
관리자페이지 글감 수정
@UserAuthAnnotation(UserAuthenticationType.OWNER) 적용
userId 파라미터 제거 및 권한체크 로직 제거
관리자페이지 멤버 삭제
@UserAuthAnnotation(UserAuthenticationType.OWNER) 적용
userId 파라미터 제거 및 권한체크 로직 제거
관리자페이지 모임 삭제
@UserAuthAnnotation(UserAuthenticationType.OWNER) 적용
userId 파라미터 제거 및 권한체크 로직 제거
글감 삭제
@UserAuthAnnotation(UserAuthenticationType.OWNER) 적용
userId 파라미터 제거 및 권한체크 로직 제거
글 삭제
@UserAuthAnnotation(UserAuthenticationType.WRITER_NAME) 적용
userId파라미터 제거 및 권한체크 로직 변경
혹시 수정할 부분이 있다면 말씀 부탁드립니다!!