Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update lint tools versions + use ts 5 #55

Merged
merged 24 commits into from
Oct 1, 2024
Merged

chore: update lint tools versions + use ts 5 #55

merged 24 commits into from
Oct 1, 2024

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Sep 24, 2024

Updating eslint and other similar packages.

@ccharly ccharly force-pushed the chore/update-lint-tools-versions branch from 371fbf7 to 2435299 Compare September 25, 2024 08:22
@socket-security Socket Security
Copy link

socket-security bot commented Sep 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@es-joy/jsdoccomment@0.41.0 None 0 113 kB brettz9
npm/@eslint-community/regexpp@4.11.1 None 0 446 kB eslint-community-bot
npm/@eslint/eslintrc@2.1.4 filesystem, unsafe 0 659 kB eslintbot
npm/@eslint/js@8.57.1 None 0 13.9 kB eslintbot
npm/@humanwhocodes/config-array@0.13.0 None 0 58.4 kB nzakas
npm/@humanwhocodes/object-schema@2.0.3 None 0 23.3 kB nzakas
npm/@metamask/eslint-config-jest@13.0.0 None 0 9.35 kB metamaskbot
npm/@metamask/eslint-config-nodejs@13.0.0 None 0 95.4 kB metamaskbot
npm/@metamask/eslint-config-typescript@13.0.0 None 0 19.1 kB metamaskbot
npm/@metamask/eslint-config@13.0.0 None 0 120 kB metamaskbot
npm/@pkgr/core@0.1.1 None 0 8.54 kB jounqin
npm/@typescript-eslint/eslint-plugin@8.7.0 None 0 2.65 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@8.7.0 None 0 18.7 kB bradzacher, jameshenry
npm/@typescript-eslint/scope-manager@8.7.0 None 0 602 kB bradzacher, jameshenry
npm/@typescript-eslint/type-utils@8.7.0 None 0 121 kB bradzacher, jameshenry
npm/@typescript-eslint/types@8.7.0 None 0 171 kB jameshenry
npm/@typescript-eslint/typescript-estree@8.7.0 None 0 587 kB jameshenry
npm/@typescript-eslint/utils@8.7.0 None 0 283 kB bradzacher, jameshenry
npm/@typescript-eslint/visitor-keys@8.7.0 None 0 19.5 kB jameshenry
npm/@ungap/structured-clone@1.2.0 None 0 26.2 kB webreflection
npm/are-docs-informative@0.0.2 None 0 13.6 kB joshuakgoldberg
npm/builtin-modules@3.3.0 unsafe 0 4.51 kB sindresorhus
npm/comment-parser@1.4.1 None 0 366 kB yavorskiys
npm/detect-indent@7.0.1 None 0 9.75 kB sindresorhus
npm/eslint-compat-utils@0.5.1 filesystem 0 53.1 kB ota-meshi
npm/eslint-plugin-es-x@7.8.0 None 0 409 kB eslint-community-bot
npm/eslint-plugin-import-x@0.5.3 None 0 638 kB jounqin
npm/eslint-plugin-jest@27.9.0 filesystem 0 325 kB simenb
npm/eslint-plugin-jsdoc@47.0.2 filesystem 0 1.38 MB gajus
npm/eslint-plugin-n@16.6.2 filesystem 0 348 kB weiran.zsd
npm/eslint-plugin-promise@6.6.0 None 0 72.5 kB eslint-community-bot
npm/eslint-scope@7.2.2 None 0 146 kB eslintbot
npm/eslint-visitor-keys@3.4.3 None 0 32.3 kB eslintbot
npm/eslint@8.57.1 environment, filesystem 0 3.04 MB eslintbot
npm/espree@9.6.1 None 0 73.6 kB eslintbot
npm/esquery@1.6.0 None 0 1.04 MB michaelficarra
npm/get-stdin@9.0.0 None 0 4.54 kB sindresorhus
npm/get-tsconfig@4.8.1 filesystem 0 105 kB hirokiosame
npm/git-hooks-list@3.1.0 None 0 5.57 kB fisker
npm/globby@13.2.2 None 0 25.1 kB sindresorhus
npm/is-builtin-module@3.2.1 None 0 3.88 kB sindresorhus
npm/is-plain-obj@4.1.0 None 0 4.08 kB sindresorhus
npm/jsdoc-type-pratt-parser@4.0.0 None 0 242 kB jsdoc-type-pratt-parser
npm/prettier-plugin-packagejson@2.5.2 None 0 5.55 kB matzkoh
npm/resolve-pkg-maps@1.0.0 None 0 15 kB hirokiosame
npm/sort-package-json@2.10.1 None 0 33.3 kB keithamus
npm/stable-hash@0.0.4 None 0 5.46 kB quietshu
npm/strip-bom@4.0.0 None 0 3.91 kB sindresorhus
npm/synckit@0.9.1 environment 0 55.7 kB jounqin
npm/ts-api-utils@1.3.0 None 0 828 kB joshuakgoldberg
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/@es-joy/jsdoccomment@0.36.1, npm/@eslint-community/regexpp@4.5.1, npm/@eslint/eslintrc@2.1.0, npm/@eslint/js@8.44.0, npm/@humanwhocodes/config-array@0.11.10, npm/@humanwhocodes/object-schema@1.2.1, npm/@metamask/eslint-config-jest@12.1.0, npm/@metamask/eslint-config-nodejs@12.1.0, npm/@metamask/eslint-config-typescript@12.1.0, npm/@metamask/eslint-config@12.2.0, npm/@types/json5@0.0.29, npm/@typescript-eslint/eslint-plugin@5.43.0, npm/@typescript-eslint/parser@5.43.0, npm/@typescript-eslint/scope-manager@5.43.0, npm/@typescript-eslint/type-utils@5.43.0, npm/@typescript-eslint/types@5.43.0, npm/@typescript-eslint/typescript-estree@5.43.0, npm/@typescript-eslint/utils@5.43.0, npm/@typescript-eslint/visitor-keys@5.43.0, npm/array-buffer-byte-length@1.0.1, npm/array-includes@3.1.8, npm/array.prototype.flat@1.3.2, npm/arraybuffer.prototype.slice@1.0.3, npm/comment-parser@1.3.1, npm/data-view-buffer@1.0.1, npm/data-view-byte-length@1.0.1, npm/data-view-byte-offset@1.0.0, npm/detect-indent@6.1.0, npm/es-abstract@1.23.3, npm/es-object-atoms@1.0.0, npm/es-set-tostringtag@2.0.3, npm/es-shim-unscopables@1.0.2, npm/es-to-primitive@1.2.1, npm/eslint-module-utils@2.11.1, npm/eslint-plugin-es@4.1.0, npm/eslint-plugin-import@2.26.0, npm/eslint-plugin-jest@27.2.2, npm/eslint-plugin-jsdoc@39.9.1, npm/eslint-plugin-n@15.7.0, npm/eslint-plugin-promise@6.1.1, npm/eslint-scope@5.1.1, npm/eslint-utils@3.0.0, npm/eslint-visitor-keys@2.0.0, npm/eslint@8.44.0, npm/espree@9.6.0, npm/esquery@1.5.0, npm/function.prototype.name@1.1.6, npm/functions-have-names@1.2.3, npm/get-symbol-description@1.0.2, npm/git-hooks-list@1.0.3, npm/globalthis@1.0.3, npm/has-bigints@1.0.2, npm/has@1.0.4, npm/internal-slot@1.0.7, npm/is-array-buffer@3.0.4, npm/is-bigint@1.0.1, npm/is-boolean-object@1.1.0, npm/is-data-view@1.0.1, npm/is-date-object@1.0.2, npm/is-negative-zero@2.0.3, npm/is-number-object@1.0.4, npm/is-plain-obj@2.1.0, npm/is-regex@1.1.4, npm/is-shared-array-buffer@1.0.3, npm/is-string@1.0.7, npm/is-symbol@1.0.3, npm/is-weakref@1.0.2, npm/isarray@2.0.5, npm/jsdoc-type-pratt-parser@3.1.0, npm/minimist@1.2.6, npm/natural-compare-lite@1.4.0, npm/object-inspect@1.13.2, npm/object.values@1.2.0, npm/prettier-plugin-packagejson@2.3.0, npm/regexp.prototype.flags@1.5.2, npm/regexpp@3.2.0, npm/safe-array-concat@1.1.2, npm/safe-regex-test@1.0.3, npm/set-function-name@2.0.2, npm/side-channel@1.0.4, npm/sort-package-json@1.57.0, npm/string.prototype.trim@1.2.9, npm/string.prototype.trimend@1.0.8, npm/string.prototype.trimstart@1.0.8, npm/strip-bom@3.0.0, npm/tsconfig-paths@3.15.0, npm/tslib@1.14.1, npm/tsutils@3.21.0, npm/typed-array-buffer@1.0.2, npm/typed-array-byte-length@1.0.1, npm/typed-array-byte-offset@1.0.2, npm/typed-array-length@1.0.6, npm/typescript@4.8.4, npm/unbox-primitive@1.0.2, npm/which-boxed-primitive@1.0.2

View full report↗︎

@ccharly ccharly force-pushed the chore/update-lint-tools-versions branch from 2435299 to 32704ca Compare September 27, 2024 07:30
@ccharly ccharly force-pushed the chore/update-lint-tools-versions branch from 32704ca to aae45b7 Compare September 27, 2024 07:31
@danroc danroc force-pushed the chore/update-lint-tools-versions branch from 7e43d4b to 4e2b067 Compare September 30, 2024 07:57
@danroc danroc force-pushed the chore/update-lint-tools-versions branch from 4e2b067 to 6f9a4a8 Compare September 30, 2024 08:15
@danroc danroc marked this pull request as ready for review September 30, 2024 08:19
@danroc danroc requested a review from a team as a code owner September 30, 2024 08:19
@ccharly ccharly changed the title chore: update lint tools versions chore: update lint tools versions + use ts 5 Sep 30, 2024
ccharly
ccharly commented Sep 30, 2024
View reviewed changes
packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts Outdated
return this.bridge.destroy();
}

async serialize() {
async serialize(): Promise<Partial<LedgerBridgeKeyringOptions>> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this, but maybe we should have a dedicated type for the state here?

ccharly
ccharly commented Sep 30, 2024
View reviewed changes
packages/keyring-eth-trezor/src/trezor-connect-bridge.ts
@@ -35,29 +40,36 @@ export class TrezorConnectBridge implements TrezorBridge {
this.trezorConnectInitiated = true;
}

dispose() {
async dispose(): Promise<void> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not async but since it's returning a Promise it makes sense to make it async

ccharly
ccharly commented Sep 30, 2024
View reviewed changes
packages/keyring-eth-trezor/src/trezor-keyring.ts
@@ -116,14 +125,14 @@ export class TrezorKeyring extends EventEmitter {
return this.bridge.model;
}

init() {
async init(): Promise<void> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not async but since it's returning a Promise it makes sense to make it async.

Also, the KeyringController is already awaiting those calls: https://github.com/MetaMask/core/blob/main/packages/keyring-controller/src/KeyringController.ts#L2199-L2201

ccharly
ccharly commented Sep 30, 2024
View reviewed changes
packages/keyring-eth-trezor/src/trezor-keyring.ts
/**
* EIP-712 Sign Typed Data
*/
// EIP-712 Sign Typed Data
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a simple comment here, since most of those method are using this pattern

@danroc danroc force-pushed the chore/update-lint-tools-versions branch from c5bda3a to 54eb2a9 Compare September 30, 2024 08:53
ccharly
ccharly commented Sep 30, 2024
View reviewed changes
Copy link
Collaborator Author

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did review (but cannot approve since I have some commits here). Left some comments with some open-questions + to explain some of the changes that were made by me.

gantunesr
gantunesr reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments

jest.config.packages.js Show resolved Hide resolved
packages/keyring-api/src/rpc-handler.ts Show resolved Hide resolved
packages/keyring-eth-ledger-bridge/src/ledger-hw-app.ts Show resolved Hide resolved
packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts Outdated Show resolved Hide resolved
packages/keyring-eth-ledger-bridge/test/document.shim.ts Show resolved Hide resolved
@ccharly ccharly mentioned this pull request Oct 1, 2024
Closed
gantunesr
gantunesr reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits!

packages/keyring-api/src/superstruct.test-d.ts Show resolved Hide resolved
packages/keyring-api/src/superstruct.ts Show resolved Hide resolved
packages/keyring-eth-ledger-bridge/test/document.shim.ts Show resolved Hide resolved
packages/keyring-eth-simple/src/simple-keyring.test.ts Show resolved Hide resolved
packages/keyring-eth-simple/src/simple-keyring.ts Show resolved Hide resolved
packages/keyring-eth-simple/src/simple-keyring.test.ts Show resolved Hide resolved
@ccharly ccharly force-pushed the chore/update-lint-tools-versions branch from c1696c4 to fff0e11 Compare October 1, 2024 13:46
@ccharly ccharly enabled auto-merge October 1, 2024 13:56
@ccharly ccharly added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit cb10ee6 Oct 1, 2024
24 checks passed
@ccharly ccharly deleted the chore/update-lint-tools-versions branch October 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroc danroc danroc left review comments

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccharly @gantunesr @danroc