chore(kyring-eth-ledger-bridge): add more comments

MetaMask · Oct 1, 2024 · b405a4e · b405a4e
1 parent f916f75
commit b405a4e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts b/packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts
@@ -123,7 +123,9 @@ export class LedgerKeyring extends EventEmitter {
     return this.bridge.destroy();
   }
 
-  async serialize(): Promise<Partial<LedgerBridgeKeyringOptions>> {
+  async serialize(): Promise<
+    Partial<LedgerBridgeKeyringOptions> // Maybe we should have a proper "state" type here instead of using this "options" type.
+  > {
     return {
       hdPath: this.hdPath,
       accounts: this.accounts,
@@ -134,7 +136,7 @@ export class LedgerKeyring extends EventEmitter {
   }
 
   async deserialize(
-    opts: Partial<LedgerBridgeKeyringOptions> = {},
+    opts: Partial<LedgerBridgeKeyringOptions> = {}, // Same question here?
   ): Promise<void> {
     this.hdPath = opts.hdPath ?? hdPathString;
     this.accounts = opts.accounts ?? [];