get Redhat tree copies working #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought only redirection in the login shell was a problem, but anyways completing implementation of the work-around for the redirection bug on redhat.
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
|
working on a cleaner version of REDIRECTION_BUG ... hang on... |
|
with the latest bug... all of the tests of re-direction are back in the test suite. The only thing needed was to ensure a sub-shell was spawned to get the re-direction to behave properly. So now, I know it's almost fully working on redhat (8 and 9) There is one niggling test I still have to put a guard around with KNOWN_REDIRECTION_BUG, a touch that should not generate a post because the minimum interval should suppress it... works on ubuntu, but not redhat... reuires further investigation, but still what is here is a big improvement. |
reidsunderland
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got redhat tree copies working
Added a KNOWN_REDIRECTION_BUG switch into the shim library tests, and provided alternatives or
disabled all the tests that will fail.
I'm pretty sure it was only in the login/initial shell before, and that subshells would work, but I'm just
making the tests pass for now to have a baseline of working sanity tests. Consider this a work-around
Have to investigate the redirection issue separately.
Also beefed up documentation about how to build considerably... example of "make" run, and some description of the test Makefile targets.