Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix has one through relationship not working #895

Open
wants to merge 3 commits into
base: 2.0
Choose a base branch
from
Open

Fix has one through relationship not working #895

wants to merge 3 commits into from

Conversation

circulon
Copy link
Contributor

This PR fixes multiple issues with the HasOneThrough relationship.

Issues addresses:

  • fixed eager loading
  • fixed geting model via related method
  • some queries missing join and incorrect where clauses
  • where_xxx would use wrong table or key

Other changes

  • Relationship query code much more readable
  • Added more DocStrings

TODO:

  • add eager loading and related loading tests

@circulon
Fixed HasOneThrough not loading distant model
7e2e551 
Fixed eager and on demand loading of distant table
use vars for tablenames to increase readability.
@circulon
Fixed HasOneThrough with additional queries
1ac4d29
@circulon
Fixed tests
4f41fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@circulon