Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.cpp + fix some things as proper nouns #27422

Open
wants to merge 11 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Sep 17, 2024

Description

Most of the file changes basically use the correct capitalization for Power-Loss Recovery and I2C and Z-Probe/Z-Probe Offset/Z-Offset and *-Axis (ex: X-Axis, Z-Axis)

Before:

  • i2c
  • power-loss recovery
  • Power-loss
  • Z probe
  • Z probe offset
  • Z offset
  • X-axis, Y-axis, Z-axis
    ...ect

After:

  • I2C
  • Power-Loss Recovery
  • Z-Probe
  • Z-Probe Offset
  • Z-Offset
  • X-Axis, Y-Axis, Z-Axis

Other changes:

  • Better understance/readbility in settings.cpp

    • Added missing comment descriptions
    • Added the Gcode command + added actual string description to comments in reports section (at bottom)
    • A bit of organize/rearrange, like some blocks out of place. Placed in order - LCD Contract, Display Sleep, LCD Brightness
    • Placed FIELD_TEST() above and prior to code as to utilize SettingsDataStruct variable declarations (as it is with the remaining code structure)
  • Added/updated language.h strings to correct/proper captialization and such.

Requirements

Benefits

Better understand of code with updated comments using correct descriptions.
Added what was missing, and easier arrangement.

Configurations

Related Issues

@classicrocker883 classicrocker883 changed the title Update settings.cpp + fix Power-Loss Recovery / I2C as proper nouns Update settings.cpp + fix Power-Loss Recovery / I2C / Z-Probe|Offset as proper nouns Sep 17, 2024
@classicrocker883 classicrocker883 changed the title Update settings.cpp + fix Power-Loss Recovery / I2C / Z-Probe|Offset as proper nouns Update settings.cpp + fix some things as proper nouns Sep 21, 2024
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant