🧑💻 CardReader::isStillPrinting #27392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_still_printing_PR
branch
from
a108bbe
to
e962c8e
Compare
InsanityAutomation
added a commit
to InsanityAutomation/Marlin
that referenced
this pull request
Oct 15, 2024
Changes to SPI in MarlinFirmware#27392 break Lulzbot TFT SPI communication. Reverting the changes to this file restore operation. Cardreader changes need investigation, as with these changes machine will boot loop with USB inserted. Removing the usb at boot, then inserting after init allows it to complete. Does not occur with all changes from this the origin PR reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card.isStillPrinting().card.methods directly in places where othercard.methods are referenced directly.IS_SD_MOUNTEDextIsBINto compare toB,I,N.card_flags_t…and…
DISABLE_DUE_SD_MMCby always returningfalsefrommedia_ready().