Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT_MOTION : update preprocessor directives #27359

Merged
merged 12 commits into from
Aug 24, 2024

Conversation

narno2202
Copy link
Contributor

Description

FT_MOTION can be used as a motion system without shaping. Shaping can be applied on X axis, Y axis or on both axes. X axis is no more mandatory.
The preprocessor directives in SanityCheck.h, ft_types.h, ft_motion.h , ft_motion.cpp, menu_motion.cpp are updated to reflect those features.
FT_MOTION tune menu is now only shown when FT_MOTION is active.

Requirements

Benefits

Configurations

Related Issues

@narno2202 narno2202 changed the title FT_MOTION : update preprocessor directive FT_MOTION : update preprocessor directives Aug 18, 2024
@narno2202
Copy link
Contributor Author

narno2202 commented Aug 22, 2024

@thinkyhead , I apologize. When i wrote it, i thought in theory (if, then ,else) and not which machine has a Y axis without an X axis. So 90% of this PR is false.
Regarding the tune menu, It feels strange to me to set the shaping frequencies whithout FTM enabled and It's the same for linear advance. It makes sense if we could set FTM and shaping on or off and choose the shaper.

@thinkyhead
Copy link
Member

It feels strange to me to set the shaping frequencies without FTM enabled…

In some cases it may make sense to hide things that wouldn't make sense to show, such as an SD Card sub-menu when no SD card is inserted. For configuration options it's a bit different. It's more-or-less standard in Marlin to keep configuration options visible in the menus so users can do setup or adjustment on the Feature without having to enable it.

thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Aug 23, 2024
@thinkyhead thinkyhead merged commit 3abe1fc into MarlinFirmware:bugfix-2.1.x Aug 24, 2024
39 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants