update SanityCheck, AZTEEG_X3_PRO does not need DIGIPOTS_I2C_SDA_* #27337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921
to
37fb26b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SanityCheck.h incorrectly errors telling users with a AZTEEG_X3_PRO with DIGIPOT_MCP4451 enabled "DIGIPOT_MCP4018/4451 requires DIGIPOTS_I2C_SDA_* pins to be defined."
This is not the case for this controller.
If you examine the circuit diagram this board is using hardware i2c pins, not software i2c so does not require these pin defines.
AZTEEG X3 PRO - schematic.pdf
Requirements
AZTEEG_X3_PRO, DIGIPOT_MCP4451
Benefits
Builds without error