Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🔨 Rename BTT SKR V2.0 PIO envs (#27301)" #27307

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jul 24, 2024

Description

This reverts commit 2f3af43 / #27301

"🔨 Rename BTT SKR V2.0 PIO envs (#27301)" does not accurately reflect what was actually done to my PR and we also specifically went from BIGTREE => BTT for board names in the past, so those unrelated changes seem backwards.

Even if we were to move everything back to "BIGTREE", it should be their actual name which is "BIGTREETECH".

Related Issues

@thinkyhead
Copy link
Member

Most of the tests/ files, which are named exactly the same as the environment to which they pertain — all except one — are prefixed with "BIGTREE_" rather than "BTT_" so I renamed the odd one out (the env and the test). The rest of the PR should be exactly as it was originally crafted. Is there any part of the original PR that should be preserved?

@thinkyhead
Copy link
Member

thinkyhead commented Jul 29, 2024

Even if we were to move everything back to "BIGTREE", it should be their actual name which is "BIGTREETECH".

A good point, which only stems due to the initiative of the original PR. Consistency is good, but there is a pretty even mixture of BTT/BIGTREE/BigTree/BIGTREETECH/BigTreeTech in naming of envs, boards, and variants. If full consistency is a goal, do we really want to change everything to either "BTT" or "BIGTREE" or "BIGTREETECH" across all references, folders, and filenames at some point? Considering this would involve changing several MOTHERBOARD names it seems like a good idea to hold off on this initiative until it can be done thoroughly. If the job had just been as small as the previous PR then it would be fine to merge it anytime, but as I've just tried to go through everything and move consistently to "BTT_" it's clear that doing a proper thoroughgoing job would be too disruptive at this moment. But we should slap it together soon after 2.1.3.

@thinkyhead thinkyhead merged commit 01b7d6c into MarlinFirmware:bugfix-2.1.x Jul 29, 2024
63 checks passed
@thisiskeithb thisiskeithb deleted the pr/revert_env_renames branch July 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants