Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong menu text for adjusting Z probe offset #26832

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

abortz
Copy link
Contributor

@abortz abortz commented Mar 2, 2024

Fix the text on the Z probe offset menu item in ProUI. The current one (recently changed) is verbose and overflows the space in the UI. The old one was perfect.

@classicrocker883
Copy link
Contributor

I agree "Update Probe Z-Offset to " is a bit too wordy, but I would argue changing that to

- LSTR MSG_XATC_UPDATE_Z_OFFSET           = _UxGT("Update Probe Z-Offset to ");
+ LSTR MSG_XATC_UPDATE_Z_OFFSET           = _UxGT("Update Z-Offset");

or just make a new MSG_:

+ LSTR MSG_UPDATE_Z_OFFSET           = _UxGT("Update Z-Offset");

@abortz
Copy link
Contributor Author

abortz commented Mar 3, 2024

@classicrocker883 this is the same text used by a half dozen different UIs. Changing it seems like a topic for a different issue/PR.

@thinkyhead this seems like an easy revert -- the text string you switched to appears only to be used by an X Axis Twist wizard.

@sjasonsmith
Copy link
Contributor

@abortz would you be able to link to the commit that changed the behavior you are reverting? If you could readily provide pictures of the before and after behavior that would be fantastic. Thanks.

@abortz
Copy link
Contributor Author

abortz commented Apr 7, 2024

Looks like it was 0f09554

Attached is an after photo, I don't have a before but the text was way too long and clipped.
PXL_20240407_155450101

@sjasonsmith sjasonsmith merged commit c31d9e7 into MarlinFirmware:bugfix-2.1.x Apr 7, 2024
61 checks passed
@abortz abortz deleted the fix_text branch April 9, 2024 21:03
RPGFabi pushed a commit to RPGFabi/Marlin that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants