Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G34 Z-Steppers Auto-Align increased range #26771

Merged
merged 5 commits into from
Apr 7, 2024

Conversation

sargonphin
Copy link
Contributor

Description

Extends the range of G34 Z Steppers Auto Align since now some bed probes are able to be very precise. Range goes from 0.01-1.0 to 0.001-1.0. Also added sanity checks for out of range values

Requirements

Requires a bed probe

@sjasonsmith
Copy link
Contributor

@sargonphin would you mind describing the setup you are using where this became a limitation?

@sjasonsmith
Copy link
Contributor

Also, if you're able to update this with the current state of bugfix-2.1.x to resolve the merge conflict that would be great. The change is simple enough that I don't see any reason not to make the change, as long as there are scenarios where this was actually limiting performance.

I would generally imagine that most printers aren't actually accurate enough on their Z axis to benefit from more than 0.01, but feel free to prove me wrong!

@sargonphin
Copy link
Contributor Author

@sjasonsmith Bed probes such as the SuperPINDA can be accurate enough that it almost always achieve accuracies under 0.01mm, being able to set the threshold lower could allow to take the full potential of the sensor. It wouldn't make a big difference in printing as this distance is too small to do anything, but at least such accuracy can be achieved :)

@InsanityAutomation
Copy link
Contributor

I agree with the change. @sargonphin just need to rebase on bugfix to get rid of the merge conflict and it should be fine. Can take a look once thats done to be sure it doesnt impact anything.

@sjasonsmith sjasonsmith merged commit 9343247 into MarlinFirmware:bugfix-2.1.x Apr 7, 2024
61 checks passed
RPGFabi pushed a commit to RPGFabi/Marlin that referenced this pull request Jun 15, 2024
* Allow G34 accuracy down to 0.001mm, previous minimum was 0.01mm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants