Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved runtime-packers #268

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Improved runtime-packers #268

merged 4 commits into from
Sep 30, 2023

Conversation

dhondta
Copy link
Contributor

@dhondta dhondta commented Sep 30, 2023

Hi @adulau !
Please note that I renamed portable-executable to pe as it has no sense to expand it while elf and macho aren't. I also fixed some packer entries sorted in pe while they should have been either in dex, elf or macho.

@adulau
Copy link
Member

adulau commented Sep 30, 2023

Thanks a lot for the contribution. It indeeds make sense to change the predicate to keep the logic.

Could you run a jq all the things? and update the PR? The tests shall pass then ;-) Thanks again.

@adulau adulau self-assigned this Sep 30, 2023
@adulau adulau merged commit 903ada0 into MISP:main Sep 30, 2023
4 checks passed
@adulau
Copy link
Member

adulau commented Sep 30, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants