Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint Update & Increase CDIP Example Time #357

Merged
merged 8 commits into from
Oct 14, 2024

Conversation

ssolson
Copy link
Contributor

@ssolson ssolson commented Oct 14, 2024

The most recent update to the Pylint package added a warning for too many position arguments in addition to current too many arguments. We are currently ignoring historical too many arguments errors due to the major refactoring that is typically required to address. As such we will also ignore the too many positional arguments.

Additionally the CDIP API seems to be taking longer to respond. Local example runs are taking ~7 min.

@ssolson ssolson self-assigned this Oct 14, 2024
@ssolson ssolson requested a review from akeeste October 14, 2024 14:28
@ssolson ssolson added the Clean Up Improve code consistency and readability label Oct 14, 2024
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Thanks @ssolson

@ssolson ssolson merged commit 6445365 into MHKiT-Software:develop Oct 14, 2024
41 checks passed
@ssolson ssolson deleted the pylint branch October 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Up Improve code consistency and readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants