Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of the text overlapping #143

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

MarcosApodaca
Copy link
Collaborator

Create the component truncated-text.component.tsx.
To avoid text overlapping, add more space in the X parameter of the text, because the ►, joined with the text.

</clipPath>

<text
x={x + 5}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this x+5?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should store it in a constant, and avoid harcoding values here directly

@brauliodiez brauliodiez merged commit 83e4c09 into Lemoncode:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants