Automatically aborts adding additional markers for an ongoing addLayers call when the clearLayers function is called. #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs call when the clearLayers function is called.
…rs call when the clearLayers function is called.
frenomus
changed the title
|
Could we get a test for this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main use case for this is when you are dynamically filtering markers that are being added into the cluster layer using chunked loading. With large marker sets it is possible for the filter conditions to change mid importation.
Previously, calling the clearLayers function would only clear markers already added. If the addLayers function was currently importing markers these would be added after the clearLayers function was called resulting in an unexpected state.
This PR essentially keeps a track of the number of times the clearLayers function was called, and aborts an addLayers process if it began when the call count was less than the current call count of clearLayers.