Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxHeightDelta setting to exclude stale data #47

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

mrfelton
Copy link
Member

This pull request introduces a new configuration option maxHeightDelta to the application, which represents the maximum acceptable difference between the block heights of the most current fee estimates. The maxHeightDelta is added to the DataProviderManager class and is used to filter out data points that don't meet the relevancy threshold criteria. The changes also include the necessary updates to the configuration files and the server setup.

Here are the most significant changes:

Configuration updates:

Codebase changes:

  • src/lib/DataProviderManager.ts: Added maxHeightDelta as a member of the DataProviderManager class. Replaced the getSortedDataPoints method with getRelevantDataPoints that filters out data points based on the maxHeightDelta. [1] [2] [3]
  • src/server.tsx: Retrieved maxHeightDelta from the configuration and passed it to the DataProviderManager constructor. [1] [2]

Test updates:

@mrfelton mrfelton added the type:enhancement Indicates new feature requests label Feb 19, 2024
@mrfelton mrfelton self-assigned this Feb 19, 2024
@mrfelton mrfelton merged commit 654ef82 into master Feb 19, 2024
1 check passed
@mrfelton mrfelton deleted the refactor branch February 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant