Merge pull request #56 from LN-Zap/fix/fee-min-filter

Filter out duplicate estimates
LN-Zap · Apr 23, 2024 · 7ac2371 · 7ac2371
2 parents 93286e0 + 2d73bdc
commit 7ac2371
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/lib/DataProviderManager.ts b/src/lib/DataProviderManager.ts
@@ -196,12 +196,10 @@ export class DataProviderManager {
       log.debug({ msg: `Estimates for dataPoint ${providerName}`, estimates });
 
       keys.forEach((key) => {
-        // Only add the estimate if it has a higher confirmation target and a lower fee
+        // Only add the estimate if it has a higher confirmation target and a lower fee.
         if (
-          (!mergedEstimates[key] && estimates[key]) ||
-          (mergedEstimates[key] &&
-            key > Math.max(...Object.keys(mergedEstimates).map(Number)) &&
-            estimates[key] < Math.min(...Object.values(mergedEstimates)))
+          key > Math.max(...Object.keys(mergedEstimates).map(Number)) &&
+          estimates[key] < Math.min(...Object.values(mergedEstimates))
         ) {
           log.debug({
             msg: `Adding estimate from ${providerName} with target ${key} and fee ${estimates[key]} to mergedEstimates`,

diff --git a/test/DataProviderManager-merge.test.ts b/test/DataProviderManager-merge.test.ts
@@ -69,6 +69,8 @@ class MockProvider3 implements Provider {
       "2": 15,
       "3": 5,
       "5": 3,
+      "6": 3,
+      "7": 3,
     });
   getAllData = () =>
     Promise.resolve({
@@ -79,6 +81,8 @@ class MockProvider3 implements Provider {
         "2": 15,
         "3": 5,
         "5": 3,
+        "6": 3,
+        "7": 3,
       },
     });
 }