cmake: Only search for MASM when using MSVC #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author sfan5 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author sfan5 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
|
CI Vulkan-Loader build queued with queue ID 41269. |
|
CI Vulkan-Loader build # 2156 running. |
|
CI Vulkan-Loader build # 2156 passed. |
juan-lunarg
suggested changes
Sep 12, 2023
|
Author sfan5 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author sfan5 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 41316. |
|
CI Vulkan-Loader build # 2158 running. |
|
CI Vulkan-Loader build # 2158 passed. |
juan-lunarg
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling with MinGW CMake somehow says it finds MASM and the build subsequently fails since gcc doesn't understand
/Faor/Od. While this could possible be a CMake bug I think it's a quick fix here.This shouldn't break anything else as MASM is restricted to MSVC and not available in other situations.
reproduction: same script as #1278 just remove the
-DUSE_MASM=OFF