cmake: Fix MinGW vulkan.pc #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 41228. |
|
CI Vulkan-Loader build # 2154 running. |
|
CI Vulkan-Loader build # 2154 passed. |
juan-lunarg
commented
Sep 12, 2023
Comment on lines
-415
to
-416
| # Set libdir path as in cmake's FindVulkan.cmake | ||
| # https://github.com/KhronosGroup/Vulkan-Loader/issues/668 |
There was a problem hiding this comment.
At one point FindVulkan.cmake didn't consider MinGW in it's search paths. It now does.
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8256
|
@sfan5 please confirm this fixes your issue. I'm sure it will but still I'd like you to test. |
|
Yep, works fine. Thanks for looking into this. |
charles-lunarg
approved these changes
Sep 12, 2023
Great to hear 👍🏾 |
|
CI Vulkan-Loader build queued with queue ID 41258. |
|
Fixed typo in commit message |
|
CI Vulkan-Loader build # 2155 running. |
|
CI Vulkan-Loader build # 2155 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts /pull/670 which produces an invalid .pc file
closes #1278