Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixed table lint #535

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Add mixed table lint #535

merged 5 commits into from
Sep 12, 2023

Conversation

chriscerie
Copy link
Collaborator

Closes #534.

This might false positive when working with an external library that expects a mixed table as it also warns against mixed tables passed into function calls. Disabling it in these cases would also disable similar cases where the user's application owns the expecting function.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Owner

@Kampfkarren Kampfkarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just some nits.

@Kampfkarren Kampfkarren merged commit 5f6c2be into Kampfkarren:main Sep 12, 2023
12 checks passed
@chriscerie chriscerie deleted the mixed-table branch September 12, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new lint for mixed table declarations
2 participants