Add readcubedata(dataset)

src/DatasetAPI/Datasets.jl

@@ -1,6 +1,6 @@
 module Datasets
 #import ..Cubes.Axes: axsym, axname, CubeAxis, findAxis, CategoricalAxis, RangeAxis, caxes
-import ..Cubes: Cubes, YAXArray, concatenatecubes, CleanMe, subsetcube, copy_diskarray, setchunks, caxes
+import ..Cubes: Cubes, YAXArray, concatenatecubes, CleanMe, subsetcube, copy_diskarray, setchunks, caxes, readcubedata
 using ...YAXArrays: YAXArrays, YAXDefaults, findAxis
 using DataStructures: OrderedDict, counter
 using Dates: Day, Hour, Minute, Second, Month, Year, Date, DateTime, TimeType, AbstractDateTime
@@ -178,6 +178,12 @@ function Base.getproperty(x::Dataset, k::Symbol)
         x[k]
     end
 end
+
+function readcubedata(ds::Dataset)
+    inmemcubes = OrderedDict(key=> readcubedata(val) for (key, val) in pairs(ds.cubes))
+    Dataset(inmemcubes, ds.axes, ds.properties)
+end
+
 Base.getindex(x::Dataset, i::Symbol) =
 haskey(x.cubes, i) ? x.cubes[i] :
 haskey(x.axes, i) ? x.axes[i] : throw(ArgumentError("$i not found in Dataset"))

test/Datasets/datasets.jl

@@ -319,6 +319,11 @@ end
     @test ds.b.data == y
     @test ds.b.chunks == b.chunks
 
+    @test ds.b.data isa AbstractDiskArray
+    inmemds = readcubedata(ds)
+    @test !isa(inmemds.b.data, AbstractDiskArray)
+
+
     ds2 = Dataset(c=c)
     savedataset(ds2, path=f, backend=:zarr, append=true)
     ds = open_dataset(f, driver=:zarr)