Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare resources in the GitHub action for test scripts #220

Merged
merged 26 commits into from
Jul 8, 2024

Conversation

jonct
Copy link
Contributor

@jonct jonct commented Jul 7, 2024

I expect that this will set up the appropriate networking for automated tests, as requested.

These steps are working here, in a fresh Ubuntu Server Live CD on VMware Fusion. I'll be watching for how they play out in GitHub's runner configuration.

FWIW I've lifted that setup into the action declaration, to keep it from cluttering otherwise clean tests in the script.

With apologies — that wasn't my remit — I've tacked on a second commit that applies this same separation of concerns to other resources like ZFS and exec bits.

Also I think apt-get update and upgrade are supposed to be GitHub's problem, rather than counting against everybody's usage individually? I could be wrong on that; I'm mostly a self-hosted GitLab guy.

@jonct jonct mentioned this pull request Jul 7, 2024
@jonct jonct closed this Jul 7, 2024
@jonct
Copy link
Contributor Author

jonct commented Jul 7, 2024

I accidentally submitted this against main and instead of develop.

It's possible that all I'm missing right now is a proper dnsmasq.conf but right now we're WIP.

@jonct jonct reopened this Jul 7, 2024
@jonct jonct changed the title Prepare resources in the GitHub action for test scripts WIP: Prepare resources in the GitHub action for test scripts Jul 7, 2024
@Lockszmith-GH
Copy link
Contributor

You can switch the into branch if you edit the PR

@jonct jonct changed the base branch from main to develop July 8, 2024 02:40
@jonct
Copy link
Contributor Author

jonct commented Jul 8, 2024

You can switch the into branch if you edit the PR

Hah! Right under my nose. I kept seeing only the title field appear, and wouldn't spot the pop-up. 🙄 Many thanks.

@Jip-Hop
Copy link
Owner

Jip-Hop commented Jul 8, 2024

Thanks! As you can see I made a mess of it again :) sorry! But the setup does work now and without using dnsmasq. Maybe some iptables rules can be removed / simplified and they definitely should be moved again from the test script into the yaml.

@Jip-Hop Jip-Hop force-pushed the github-actions branch 2 times, most recently from 4f67905 to 92687a0 Compare July 8, 2024 15:43
@Jip-Hop Jip-Hop changed the title WIP: Prepare resources in the GitHub action for test scripts Prepare resources in the GitHub action for test scripts Jul 8, 2024
@Jip-Hop Jip-Hop merged commit 2d3ae20 into Jip-Hop:develop Jul 8, 2024
1 check passed
@Jip-Hop
Copy link
Owner

Jip-Hop commented Jul 8, 2024

Thanks a lot @jonct! Even though I did some cleanup and merged this into develop, feel free to suggest improvements :)

@jonct
Copy link
Contributor Author

jonct commented Jul 8, 2024

Niiiiiiiice! 💯 Full endorsement. No notes.

@Jip-Hop
Copy link
Owner

Jip-Hop commented Jul 9, 2024

Hmm the test suddenly starts failing...

Podman: https://github.com/Jip-Hop/jailmaker/actions/runs/9850014285/job/27194605669

Error: netavark: Netlink error: Operation not permitted (os error 1)

Docker: https://github.com/Jip-Hop/jailmaker/actions/runs/9849986977/job/27194527864

Could not execute systemctl:  at /usr/bin/deb-systemd-invoke line 145.

@Jip-Hop Jip-Hop mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants