Skip to content

Commit

Permalink
Fix stats (accel-sim#231)
Browse files Browse the repository at this point in the history
* fix shared memory and l1d cache bankconflict stat and add shmem benchmark

* this change requires dev branch of app collection

---------

Co-authored-by: JRPan <25518778+JRPan@users.noreply.github.com>
  • Loading branch information
barnes88 and JRPan committed Sep 3, 2024
1 parent 3812e3b commit 3289681
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pipeline {
source ./gpu-simulator/setup_environment.sh
rm -rf ./gpu-app-collection
git clone git@github.com:accel-sim/gpu-app-collection.git
git clone -b dev git@github.com:accel-sim/gpu-app-collection.git
source ./gpu-app-collection/src/setup_environment
srun -c20 make rodinia_2.0-ft GPU_Microbenchmark -j20 -C ./gpu-app-collection/src
./gpu-app-collection/get_regression_data.sh
Expand Down
7 changes: 7 additions & 0 deletions util/job_launching/apps/define-all-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ GPU_Microbenchmark:
- shared_lat:
- args:
accel-sim-mem: 1G
- shared_bank_conflicts:
## argument 1 kernel has conflicts
- args: 1
accel-sim-mem: 1G
## argument 2 kernel doesn't have conflicts
- args: 2
accel-sim-mem: 1G
- MaxFlops:
- args:
accel-sim-mem: 1G
Expand Down
2 changes: 2 additions & 0 deletions util/job_launching/stats/example_stats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ collect_aggregate:
- 'total dram reads\s*=\s*(.*)'
- 'total dram writes\s*=\s*(.*)'
- 'kernel_launch_uid\s*=\s*(.*)'
- 'gpgpu_n_shmem_bkconflict\s*=\s*(.*)'
- 'gpgpu_n_l1cache_bkconflict\s*=\s*(.*)'


# These stats are reset each kernel and should not be diff'd
Expand Down
14 changes: 12 additions & 2 deletions util/plotting/correl_mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,18 @@
plottype="log",
stattype="counter",
),
CorrelStat(
chart_name="DRAM Reads",
CorrelStat(chart_name="Shared Memory Bank Conflicts",
plotfile="shmem-bank-conflict",
hw_eval="np.average(hw[\"l1tex__data_bank_conflicts_pipe_lsu_mem_shared_op_ld.sum\"])\
+ np.average(hw[\"l1tex__data_bank_conflicts_pipe_lsu_mem_shared_op_st.sum\"])",
hw_error=None,
sim_eval="float(sim[\"gpgpu_n_shmem_bkconflict\s*=\s*(.*)\"])",
hw_name="all",
drophwnumbelow=0,
plottype="log",
stattype="counter"
),
CorrelStat(chart_name="DRAM Reads",
plotfile="dram-read-transactions",
hw_eval='np.average(hw["dram__sectors_read.sum"])',
hw_error=None,
Expand Down

0 comments on commit 3289681

Please sign in to comment.